feat: Implement DeviceProvider for IOS-XR#263
Open
sven-rosenzweig wants to merge 2 commits intomainfrom
Open
Conversation
sven-rosenzweig
force-pushed
the
feat/iosxr_deviceprovider
branch
from
a56b0db to
fd96ddc
Compare
Contributor
Author
|
merge #145 first. afterwards rebase the changes of this pr |
hardikdr
added
the
area/switch-automation
sven-rosenzweig
force-pushed
the
feat/iosxr_deviceprovider
branch
from
fd96ddc to
d7270c4
Compare
sven-rosenzweig
force-pushed
the
feat/iosxr_deviceprovider
branch
from
d7270c4 to
61d298c
Compare
sven-rosenzweig
force-pushed
the
feat/iosxr_deviceprovider
branch
from
61d298c to
1031e6e
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| } `json:"interface-configuration"` | ||
| } | ||
|
|
||
| func (i *Ifaces) XPath() string { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (i *Ifaces) XPath() string { | |
| func (*Ifaces) XPath() string { |
| func MapInterfaceSpeedToNumeric(speed IFaceSpeed) (int32, error) { | ||
| switch speed { | ||
| case Speed10G: | ||
| return 10000, nil |
Contributor
There was a problem hiding this comment.
Suggested change
| return 10000, nil | |
| return 10_000, nil |
nit: you can format numbers like this. Makes it a bit easier to read perhaps.
| if err != nil { | ||
| return []provider.DevicePort{}, fmt.Errorf("failed to map interface speed to numeric value: %w", err) | ||
| } | ||
| if s != "" { |
Contributor
There was a problem hiding this comment.
I think that ExtractInterfaceSpeedFromName should never return an empty string with a non-nil error. So in theory this check shouldn't be needed.
|
|
||
| n, err := MapInterfaceSpeedToNumeric(s) | ||
| if err != nil { | ||
| return []provider.DevicePort{}, fmt.Errorf("failed to map interface speed to numeric value: %w", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| return []provider.DevicePort{}, fmt.Errorf("failed to map interface speed to numeric value: %w", err) | |
| return nil, fmt.Errorf("failed to map interface speed to numeric value: %w", err) |
|
|
||
| const Manufacturer = "Cisco" | ||
|
|
||
| // Model is the chassis model of the device, e.g. "NCS-57C3-MOD-SYS". |
Contributor
There was a problem hiding this comment.
Comments should start with the Name of the type. also applies to the SystemTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement DeviceProvider for IOS-XR